markdig fixes - Part 3 #2554
Merged
markdig fixes - Part 3 #2554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
added
the
migration-fixes
rpetrusha
approved these changes
Jun 6, 2019
| @@ -596,7 +596,7 @@ | |||
| <Docs> | |||
| <param name="tasks">The array of tasks from which to continue.</param> | |||
| <param name="continuationFunction">The function delegate to execute asynchronously when all tasks in the <paramref name="tasks" /> array have completed.</param> | |||
| <param name="continuationOptions">One of the enumeration values that controls the behavior of the created continuation task. The NotOn* or OnlyOn* values are not valid.</param> | |||
There was a problem hiding this comment.
The strings NotOn* or OnlyOn* and NotOn* and OnlyOn* are found in a number of other overloads with a TaskContinuationOptions parameter. Do you want to change those as well?
There was a problem hiding this comment.
You mean in other types @rpetrusha?
There was a problem hiding this comment.
No. At least I thought that there were additional occurrences in this type.
Co-Authored-By: Ron Petrusha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.